search

bundit / kord

Spotify, Soundcloud, and YouTube all in one website!
https://www.kord.app
MIT License
646 stars 73 forks source link

PWA not available due to failing to load manifest.json #24

Open Khaoz-Topsy opened 3 years ago

Khaoz-Topsy commented 3 years ago

Just started trying out your app, Its great! I wanted to "install" your app as desktop app, however the option isn't available. I see that the service worker that is packaged with the Create React App exists sw.js, but the manifest.json is missing.

Looking a bit deeper I see that you do have a manifest.json and the file loads correctly on the landing page. But when using the player it does not load the manifest.json. It may be something with being in the /app directory and/or some url rewrite rules in express 🤔

bundit commented 3 years ago

@Khaoz-Topsy Thanks for reporting this issue. Yeah I see that manifest.json is hosted at /app/manifest.json but my manifest "start_url" is set to /app/library which doesn't make sense since the entire app is hosted at /app.

I think this may be the problem but I'm not entirely sure.

bundit commented 3 years ago

c18ab3d6491a77e16b46e611fedd1b60458d927b Allows "installation" from the landing page which will redirect to /app/library. Still having trouble getting the manifest to load correctly from /app but this will do for now