Hexadecimal values classed as errors

bungcip / better-toml

toml extension for vs code editor

74 stars 13 forks source link

Hexadecimal values classed as errors #28

Open alecks opened 4 years ago

alecks commented 4 years ago

Hex codes throw errors when used without being wrapped in quotes.

repi commented 4 years ago

We ran into this also in some toml fields that look like this:

[[licenses.clarify]]
name = "webpki"
expression = "ISC"
license-files = [
    { path = "LICENSE", hash = 0x001c7e6c }
]

cc @Jake-Shadle

The toml spec does specify that hexadecimal numbers should be supported, so would be great to add support for it in the extension (or at least not categorize as errors).

jplatte commented 3 years ago

This looks to be a duplicate of #12. I think it's time for a fork though, the author has no public activity on GitHub for the entire year.

barafael commented 3 years ago

For reference, "Even better TOML" exists and does not have this issue as it supports toml 1.0.

ralpha commented 2 years ago

Like @barafael stated "Even better TOML" (also called "Taplo") does not have this problem. Although it is still in its early stages it works in most cases. But as this repo ("Better TOML") did not have any updates since 2019 it might be worth a look.