Syntax validation rejects valid input

bungcip / better-toml

toml extension for vs code editor

75 stars 13 forks source link

Syntax validation rejects valid input #5

Closed LeopoldArkham closed 7 years ago

LeopoldArkham commented 7 years ago

Hey,

The extension doesn't seem to know that all string and array types are considered homogeneous, as per the standard.

Paste the 'arr1' through 'arr5' lines from the link above to reproduce.

Thanks for the useful extension! BR

bungcip commented 7 years ago

Hi @LeopoldArkham, thanks for your report. I think this problem can be fixed with just upgrading node-toml package version.

bungcip commented 7 years ago

after futher investigation, I think the problem is not node-toml package because the input can be parsed. Syntax hightlighting in toml.tmLanguage is the culprit.

bungcip commented 7 years ago

Ok. I already push the fix in new branch 0.3. just need to release this in weekends.

new_toml

bungcip commented 7 years ago

version 0.3 already released so I will close this issue.

LeopoldArkham commented 7 years ago

Awesome!