bunkerchat / bunker

Realtime chat with node, socket.io, angular
http://bunkerchat.net
MIT License
20 stars 13 forks source link

Redoing router stuff #445

Closed JasonMore closed 4 years ago

JasonMore commented 4 years ago

Was trying to work on https://github.com/bunkerchat/bunker/issues/440 but sadly it didn't work out. I felt like some of this was good, so I wanted to keep the work.

🔧 updated react-redux 🔧 updated redux toolkit 🔧 updated react-router 🔥 killed connected-react-router cause react-router guys don't like it https://reacttraining.com/react-router/web/guides/redux-integration 💰 switched things to useSelector cause @xjpro said its awesome. Spoiler he's right again 🔥 killed <DocumentTitle />

Bonus, I noticed we don't need to render every room every time anymore, which is something I've wanted to do for a while which sets us up for virtual message scrolling https://github.com/bvaughn/react-virtualized which I have sorta setup in another branch.