bunnech / cellot

Learning Single-Cell Perturbation Responses using Neural Optimal Transport
BSD 3-Clause "New" or "Revised" License
109 stars 9 forks source link

The R2 metric #19

Closed Flroa10086633 closed 4 months ago

Flroa10086633 commented 4 months ago

Hi ! In ./scripts/evaluate.py, The r2 between the observed and predicted gene expression is calculated using "pd.Series.corr(mut, mui)". However, this function only returns the Pearson correlation coefficient (PCC). I is there anything wrong ?

stefangstark commented 4 months ago

Hi, thanks for spotting this! I took a closer look myself and we actually do report the correlation coefficient but are calling it r^2 by mistake. Also if you look in the text we even define r^2 as the correlation coefficient, and some models are reporting a negative value for r^2. So basically all the r^2 in the paper should really be r.

In terms of model comparisons, this won't change any statements we make. Hopefully you don't feel mislead about the difference in interpretation between r and r^2. We will look into what we can do about amendments.