search

bunny-mod / Bunny

A client mod for Discord mobile, fork of Vendetta
BSD 3-Clause "New" or "Revised" License
1.45k stars 34 forks source link

new menu causes crash #2

Closed riichi67 closed 8 months ago

riichi67 commented 8 months ago

steps to reproduce:

  1. press settings icon near plugin/theme
  2. try to exit it with gesture/back button/etc
  3. crash! (just exits the app)

notes:

if you try to do the same with new attachment menu, it kills swiping back to channel list (you can do it only with gesture/back button)

riichi67 commented 8 months ago

another note: attachment menu thing happens on stock vd too

pylixonly commented 8 months ago

Mhm yeah, a quirk of the new component.. it demands the component to stay on render until the menu fully closes. When you press back, it exits the page, thus unrender the component before the menu and boom

pylixonly commented 8 months ago

I'm pretty sure that's unintended, since there's no "back" on iOS (where the component is built most likely)... I'll try to get around this or just resort back to the action sheet

PalmDevs commented 8 months ago

This happens inside the Design systems > Context menu page under Staff Settings section too.

pylixonly commented 8 months ago

Implemented a fix in 34bc869a07004c6b120b2fb8a3e8a03c984cb68d