search

bunny-mod / Bunny

A client mod for Discord mobile, fork of Vendetta
BSD 3-Clause "New" or "Revised" License
1.45k stars 34 forks source link

bug: Background image not loaded until theme is reselected #53

Closed pterror closed 1 month ago

pterror commented 4 months ago

not OP of this message, but it's the same issue: https://discord.com/channels/1196075698301968455/1210652540757090315/1225091476938031114

image backgrounds on themes are a bit broken on bunny.

If I restart discord the background disappears but changing (or deselecting) theme and back caused the background to show like normal

pterror commented 4 months ago

maybe patchChatBackground is running before initThemes finishes? maybe

updateThemes().then(
  patchChatBackground,
  e => console.error("Failed to update themes", e)
);

might work... or making initThemes async and awaiting it:

return updateThemes().catch(e => console.error("Failed to update themes", e));

(i have no idea how this thing works though so i may be on the wrong track completely)

pylixonly commented 1 month ago

can you recheck if this is still an issue?

pterror commented 1 month ago

my bad, it is still an issue, i've updated just now just to recheck:

On Wed, 11 Sept 2024, 9:33 am pylix, @.***> wrote:

Closed #53 https://github.com/pyoncord/Bunny/issues/53 as completed.

— Reply to this email directly, view it on GitHub https://github.com/pyoncord/Bunny/issues/53#event-14211049583, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUOELFXQQLJ74ZROUXJ4ZU3ZV7W23AVCNFSM6AAAAABI2UYBRKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGIYTCMBUHE2TQMY . You are receiving this because you authored the thread.Message ID: @.***>