search

bunny-mod / Bunny

A client mod for Discord mobile, fork of Vendetta
BSD 3-Clause "New" or "Revised" License
1.45k stars 34 forks source link

change: Error boundary colours #96

Closed Moodzz1 closed 2 days ago

Moodzz1 commented 3 days ago

Describe the change It's for the new crash screen merged from dev

The outer background is BACKGROUND_PRIMARY The inner background is BG_BASE_PRIMARY

I am requesting for the outer background to be changed to BG_BASE_SECONDARY and inner background to CARD_PRIMARY_BG

BG_BASE_SECONDARY - outer background for settings pages CARD_PRIMARY_BG - plugin/theme cards This change is a very small and probably dumb one but for the sake of consistency and theming purposes it would genuinely help.

pylixonly commented 3 days ago

The outer background is BACKGROUND_PRIMARY

Use of BACKGROUND_PRIMARY is retained from Vendetta: https://github.com/vendetta-mod/Vendetta/blob/rewrite/src/ui/safeMode.tsx#L18-L22 How could the change affect the consistency? Is this something recently affected or it has been a while? And why should it be BG_BASE_SECONDARY?

CARD_PRIMARY_BG - plugin/theme cards

The colors of these cards are decided by Discord itself, I'm can't see how it could be inconsistent and trying to change this color would be hacky somewhat. Do they differ from Discord's use?

Moodzz1 commented 3 days ago

The outer background is BACKGROUND_PRIMARY

Use of BACKGROUND_PRIMARY is retained from Vendetta: https://github.com/vendetta-mod/Vendetta/blob/rewrite/src/ui/safeMode.tsx#L18-L22 How could the change affect the consistency? Is this something recently affected or it has been a while? And why should it be BG_BASE_SECONDARY?

BG_BASE_SECONDARY is used across settings pages, members list, profiles and even bunny's own pages. It would be more consistent in that case

Examples

As far as I'm aware the only things that still uses background_primary are is the search page and "jump to message"

CARD_PRIMARY_BG - plugin/theme cards

The colors of these cards are decided by Discord itself, I'm can't see how it could be inconsistent and trying to change this color would be hacky somewhat. Do they differ from Discord's use?

Not sure what you mean by this (sorry)

Moodzz1 commented 3 days ago

Also there are themes, such as catppuccin, which follow strict colour pallets and getting around the backgrounds being the same colour seems impossible to me lol. Catppuccin isn't the only theme like this probably

pylixonly commented 3 days ago

Not sure what you mean by this (sorry)

Card is not our own component, rather Discord's. We don't define its colors.

Moodzz1 commented 3 days ago

Oh right. Well either way themers can still change the colour of CARD_PRIMARY_BG. Just like the other string it's used by discord in many places and even on bunny's own pages

Examples