Currently, the project has about 100 SwiftLint warnings which were not fixed yet. While most of them are style warnings which could be fixed easily, some need a little more work. For example, I noticed the following:
[x] There's a UIColor(named: "ModernDark") in several places, but no "ModernDark" color in the asset catalog
[x] There's several fatalError calls without explanations what the developer error is in the cases (hard to guess for me)
[x] There's a NSLocalizedString("Loading...", comment: "") call, but no such entry in Localizable.strings
[x] Some types like GrammarViewController have just too much code in them, some of the logic should be extracted
Getting a second opinion / explanation why would be great for those.
Currently, the project has about 100 SwiftLint warnings which were not fixed yet. While most of them are style warnings which could be fixed easily, some need a little more work. For example, I noticed the following:
UIColor(named: "ModernDark")in several places, but no "ModernDark" color in the asset catalogfatalErrorcalls without explanations what the developer error is in the cases (hard to guess for me)NSLocalizedString("Loading...", comment: "")call, but no such entry inLocalizable.stringsGrammarViewControllerhave just too much code in them, some of the logic should be extractedGetting a second opinion / explanation why would be great for those.