search

bunpro-srs / BunPro-iOS

iOS companion app for the BunPro Japanese grammar learning service.
https://bunpro.jp/
MIT License
5 stars 1 forks source link

Document and apply unified style for commit messages #3

Closed Jeehut closed 5 years ago

Jeehut commented 5 years ago

I'm not sure if you already have a clear set of rules for how the commit messages should look like. But if you don't, I suggest we use the seven rules explained in this post which is probably the most widespread set of commit message rules.

Especially, I'm for using the imperative mood instead of the past tense (which you seem to apply), the main reason being this:

Git itself uses the imperative whenever it creates a commit on your behalf

Otherwise the history reads like sometimes imperative (like merge commits), sometimes past.

Jeehut commented 5 years ago

Fixed via ada90c7df6fe07f77f52d99a4461143f7c222061.