search

bunpro-srs / BunPro-iOS

iOS companion app for the BunPro Japanese grammar learning service.
https://bunpro.jp/
MIT License
5 stars 1 forks source link

Fix interminable loading screen by making grammarIdentifier optional #37

Closed qmoreland-cricut closed 2 years ago

qmoreland-cricut commented 2 years ago

Currently, there seems to be a bug where manual vocab is causing the reviews from the API to not get decoded properly. This seems to be because the grammarIdentifier is nil. This PR prevents the failure of the decoder by making the grammarIdentifier optional and nil coalescing to zero in the init.

Edit: Link to relevant feedback post on the community board: https://community.bunpro.jp/t/ios-app-feedback/137/124?u=number2dadd

Rion-Kaneshiro commented 2 years ago

Tested it just now and it seems like the grammar database can not be updated with this change. I'll look further into it.

qmoreland-cricut commented 2 years ago

Tested it just now and it seems like the grammar database can not be updated with this change. I'll look further into it.

Hmmm interesting. I'll take a look tonight too. I was getting a 503 when the app was trying to request grammar points, so maybe there is something happening server side as well?

Rion-Kaneshiro commented 2 years ago

That seems to be the case. I asked Jake if something went wrong there, answer‘s pending though.

qmoreland-cricut commented 2 years ago

Any update on the grammar points issue being server-side vs. client-side?

qmoreland-cricut commented 2 years ago

Looks like this got fixed elsewhere