search

bunq / sdk_csharp

C# SDK for bunq API
MIT License
35 stars 22 forks source link

Added support for .net standard 2.0 #104

Closed nduijvelshoff closed 6 years ago

nduijvelshoff commented 6 years ago
OGKevin commented 6 years ago

@nduijvelshoff could you please follow the PR guide lines as described here: https://raw.githubusercontent.com/bunq/sdk_csharp/develop/.github/PULL_REQUEST_TEMPLATE.md

Which should fix the failing checks.

OGKevin commented 6 years ago

@nduijvelshoff and please rebase your commit to the following pattern.

https://github.com/bunq/sdk_csharp/blob/47197021c6ce25d0fd17b9b58fddc7fb26a192ac/.zappr.yaml#L4

To fix the failing commit msg check.

nduijvelshoff commented 6 years ago

@OGKevin is it now as required?

OGKevin commented 6 years ago

@nduijvelshoff rename your commit from Closes to Add support for net standard 2. and the check should pass. If not ill just rebase it for you 😉

nduijvelshoff commented 6 years ago

@OGKevin I think I did it now, but it's still failing.

OGKevin commented 6 years ago

Its not good to commit on the develop branch and create an MR from there. Tip for future contributions. I will rebease it for you. But this means that i would need to force push to your develop branch what certainly is not/how it should be done.

OGKevin commented 6 years ago

Yup and i broke it 😂

Please create a new MR, but then from a diff branch then develop please. Sorry for the inconvenience.

OGKevin commented 6 years ago

you can use https://regexr.com/ to ensure that your commit msg is according to the patter.