search

bunq / sdk_csharp

C# SDK for bunq API
MIT License
35 stars 22 forks source link

Wrong return type for NotificationFilterUrlUser.List() #131

Open mbedeker opened 4 years ago

mbedeker commented 4 years ago

Steps to reproduce:

Calling NotificationFilterUrlUser.List()

What should happen:

It should have BunqResponse<List<NotificationFilterUrl>> as a return type. not BunqResponse<List<NotificationFilterUrlUser>>

What happens:

NotificationFilterUrlUser.List() Serializes the response to a List<NotificationFilterUrlUser>, but the response of the endpoint gives a List<NotificationFilterUrl> back.

So if there are notification filters registered, then it serializes to an array of empty objects. I've tested this by changing the returnvalue of the NotificationFilterUrlUser.List() to a BunqResponse<List<NotificationFilterUrl>>, and then there are actual values returned.

SDK version and environment