search

bunq / sdk_csharp

C# SDK for bunq API
MIT License
35 stars 22 forks source link

NotificationFilterUrlUser.Create throws unexpected exception #132

Open mbedeker opened 4 years ago

mbedeker commented 4 years ago

Steps to reproduce:

When calling NotificationFilterUrlUser.Create there is a valid response, but because the method ends with ProcessForId(responseRaw), an exception is thrown, mainly because there is no Id in the root of the response.

What should happen:

not really sure.. it should at least not throw an exception

SDK version and environment

bluewalk commented 4 years ago

Confirmed, experiencing the same issue. The notification filter however, is created.

kdekok commented 4 years ago

This is still an issue. responseobject is of type NotificationFilterUrl instead of Id. The SDK uses FIELD_ID contstant to unwrap the json and crashes there.

janssen-io commented 7 months ago

Is this SDK still maintained by Bunq? It seems absurd to me that this issue (together with #131) just don't get fixed in four years time.

Edit: from this comment on the PHP SDK project, I found out that we can use the NotificationFilterUrlUserInternal.CreateWithListResponse([]) (or NotificationFilterUrlMonetaryAccountInternal) to replace the list of the callback URLs. However, these classes don't offer a replacement for the List operation. So not sure what's the best way to append a callback URL at the moment.

bluewalk commented 7 months ago

@janssen-io it indeed seems that bunq has stopped maintaining this SDK although the bot keeps regenerating the code...