search

bunq / sdk_csharp

C# SDK for bunq API
MIT License
35 stars 22 forks source link

Response is missing response headers and pagination #5

Closed dnl-blkv closed 7 years ago

dnl-blkv commented 7 years ago

How to Reproduce

  1. Make a valid listing request to bunq API via the C# SDK
  2. Make a valid get/put/post/delete request to bunq API via the C# SDK

What Should Happen

  1. The response contains response headers and pagination
  2. The response contains response headers

What Happens

  1. The response does not contain response header nor pagination
  2. The response does not contain response header

Notes

  1. The structural fix would be to introduce BunqResponse object which, besides the response model, includes the response headers and pagination
dnl-blkv commented 7 years ago

@OGKevin This is a breaking change; in beta-stage it means updating the minor version. Let us call it 0.10.0 :)

OGKevin commented 7 years ago

Closing in favour of #6