search

bunq / sdk_csharp

C# SDK for bunq API
MIT License
35 stars 22 forks source link

feature/58 - Rename constants concerning PascalCase convention #68

Closed kid-cavaquinho closed 6 years ago

kid-cavaquinho commented 6 years ago

This PR closes/fixes the following issues:

OGKevin commented 6 years ago

Hey @antao,

Thanks for this pr!

However there are some issues:

  1. Could you please revert the changes in all the generated files. As explained here: https://github.com/bunq/sdk_csharp/issues/58#issuecomment-354113363

  2. The pr template has not been merged yet and therefore you might have missed the commit pattern explanation. Could you please rebase your commit and rename it according to the following regex: '([A-Za-z0-9 ]+)\. (\(bunq\/sdk_csharp#[0-9]+\))'