Constants following PascalCase convention

bunq / sdk_csharp

C# SDK for bunq API

MIT License

35 stars 22 forks source link

Open kid-cavaquinho opened 6 years ago

kid-cavaquinho commented 6 years ago

Closes bunq/sdk_csharp/issues/58 (And what a struggle with that commit regex 🙃)
- [x] Tested

OGKevin commented 6 years ago

@antao 😁 Nice on getting the commits right!

And thanks for this pull request!

OGKevin commented 6 years ago

@sandervdo you're up, please 👀

OGKevin commented 6 years ago

Total tests: 36. Passed: 36. Failed: 0. Skipped: 0.

All tests are passing. 👏.

Because this PR doenst need any extra tests, I'm marking the Tested task as done.

OGKevin commented 6 years ago

@antao FYI I've pushed some minor changed, be sure to pull before you push new changes 👍

kid-cavaquinho commented 6 years ago

Thanks for the push @OGKevin

OGKevin commented 6 years ago

@antao I dont understand ? Why did you close this pull request ? There is nothing wrong with it!

kid-cavaquinho commented 6 years ago

@OGKevin I did not even noticed I've closed it. My bad! Thanks for re-opening it.