search

bunq / sdk_csharp

C# SDK for bunq API
MIT License
35 stars 22 forks source link

Regenerated code with correct object types. (bunq/sdk_csharp#51) #79

Closed OGKevin closed 6 years ago

OGKevin commented 6 years ago

//: # (Thanks for opening this pull request! Before you proceed please make sure that you have an issue that explains what this pull request will do. Make sure that all your commits link to this issue e.g. "My commit. (bunq/sdk_csharp#)". If this pull request is changing files that are located in "BunqSdk/Model/Generated" then this pull request will be closed as these files must/can only be changed on bunq's side.)

This PR closes/fixes the following issues:

OGKevin commented 6 years ago

@epels yes the removal of OBJECT_TYPE is intentional.

The other comment I dont understand do you have an example ?

epels commented 6 years ago

@OGKevin Example in BillingContractSubscription: before, we returned BunqResponse<BillingContractSubscription> and you're changing that to BunqResponse<int>.

OGKevin commented 6 years ago

@epels that has to do with the view definitions 😉.