search

bunq / sdk_csharp

C# SDK for bunq API
MIT License
35 stars 22 forks source link

.net standard 2.0 support #93

Closed fschaal closed 6 years ago

fschaal commented 6 years ago

Realy great to see the new SDK! Any chance we will see added support for .net standard 2.0 soon?

OGKevin commented 6 years ago

Hey @fschaal,

See #26

It is indeed on the roadmap, however feel free to contribute this your self! As my c# skills are not as good as the other 3 SDK's. So i would have to do some reaserch on this topic to even know what needs to be done to make the SDK work on higher .net standards.

fschaal commented 6 years ago

@OGKevin, sure I will see if I can add support for .net standard 2.0 :) I'll let you know if I have any questions.

OGKevin commented 6 years ago

@fschaal appreciate it.

fschaal commented 6 years ago

@OGKevin, Did some tests this morning and the port to 2.0 should be fairly easy. Targeting 2.0 builds successfully and most of the tests pass. Some fail though but that's most likely due to my config on sandbox.

OGKevin commented 6 years ago

@fschaal that is good to hear, let me know if changes are required in the generated code. Once you have the port done and created a merge request ill take a look at the tests.