search

bunq / sdk_java

Java SDK for bunq API
MIT License
49 stars 23 forks source link

expose ApiEnvironmentType members and add pinnedKey #100

Closed tubbynl closed 6 years ago

tubbynl commented 6 years ago

i'm using mostly the generated model classes of sdk_java in my project in combination with an externally configured okhttp client and gson so i can correctly setup request handling/throttling and stuff

but currently properties of ApiEnvironmentType are not exposed, as well as the pinned keys in ApiClient

pull request upcoming ;)

tubbynl commented 6 years ago

ok, this is the end of the road for me.

i've spent too much time on applying code-formatting and all kind of (internal) code review standards, these "high" standard currently impede on fixing the larger anti-pattern existing in this implementation. my intention was to contribute some changes on the road away from using statics/singleton patterns. and an will share some content on why this is considered anti-pattern

i'm currently setting up a poc on the bunq api and the only thing i can re-use from this project is the generated models and based on the code for the login / request / response validation i can rebuild this things using spring RestTemplate and RequestInterceptors

i thank you guys for your time and for the shared code, if time permits i will share my implementation which is bound to the spring framework.

close as-you-wish

OGKevin commented 6 years ago

Shame, thanks for the contribution nevertheless.