#100 moved pinnedKey to ApiEnvironmentType

bunq / sdk_java

Java SDK for bunq API

MIT License

49 stars 24 forks source link

#100 moved pinnedKey to ApiEnvironmentType #101

Closed tubbynl closed 6 years ago

tubbynl commented 6 years ago

moved the pinnedKeys to ApiEnvironmentType

OGKevin commented 6 years ago

@tubbynl please rebase your commits to follow the following pattern. https://github.com/bunq/sdk_java/blob/7ed15ad7762b88f58de44ca1c83a4b1cdea6ae08/.zappr.yaml#L7

OGKevin commented 6 years ago

@tubbynl you can ignore the 80 line thing, the bot has been reconfigured and on your next push it should check for length of 100. Sorry for the inconvenience.

tubbynl commented 6 years ago

fails at com.bunq.sdk.model.generated.endpoint.CardDebitTest > orderNewMaestroCardTest FAILED com.bunq.sdk.exception.PleaseContactBunqException at CardDebitTest.java:80

but that probably also fails on a build on the develop branch as-is

tubbynl commented 6 years ago

see #100 close as-you-wish

OGKevin commented 6 years ago

@patrickdw1991 please 👁 the failing test is offline HSM.

OGKevin commented 6 years ago

@patrickdw1991 pushed.

OGKevin commented 6 years ago

@andrederoos