search

bunq / sdk_java

Java SDK for bunq API
MIT License
49 stars 24 forks source link

extracted header-magic as enum (bunq/sdk_java#93) #102

Closed tubbynl closed 6 years ago

tubbynl commented 6 years ago

i extracted magic constants into BunqHeader enum, added some junit tests on it

behaviour is as-is, but tests are not really runnable locally

i'm using the bunq api currently in a spring-boot setup using rest-template, most of the gson/models i can use for deserializing the responses and in order to mimic the header handling i needed to copy some of the header names into my project.

i extracted that into an BunqHeader enum which you see here, if this get's into the sdk_java project i can remove this from my project :)

tubbynl commented 6 years ago

i've processed the formatting thingies :)

tubbynl commented 6 years ago

i can't really see what's up with

com.bunq.sdk.model.generated.endpoint.CardDebitTest > orderNewMaestroCardTest FAILED com.bunq.sdk.exception.BadRequestException at CardDebitTest.java:80

but i think the formatting-relevant-header stuff is functional now; i intent to add some more tests with relevant request/response header content to validate that

OGKevin commented 6 years ago

@tubbynl there are still some comments open.

It seems that your commit messages are still not passing. Your missing .(periods). But i will change the regex to approve commits without periods.

tubbynl commented 6 years ago

please provide a link to a formatting thing i can import into intellij, it's not doable

OGKevin commented 6 years ago

@tubbynl this is build in, see https://www.jetbrains.com/help/clion/reformatting-source-code.html

Op 19/06/2018 om 09:56 schreef Michaël van de Giessen:

please provide a link to a formatting thing i can import into intellij, it's not doable

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bunq/sdk_java/pull/102#issuecomment-398309358, or mute the thread https://github.com/notifications/unsubscribe-auth/ARGTBlipxvHcCJK8egz6spgk0igYOAZyks5t-K6jgaJpZM4Uq69a.

-- Kevin Hellemun Backend developer and Github https://github.com/bunq maintainer.