bunq / sdk_java

Java SDK for bunq API
MIT License
49 stars 24 forks source link

OauthAuthorizationUri creates incorrect URL #126

Closed Nayels closed 4 years ago

Nayels commented 4 years ago

Steps to reproduce:

  1. Create OauthAuthorizationUri with state

What should happen:

https://oauth.bunq.com/auth?response_type=code&redirect_uri=redirecturi&client_id=client_id&state=state

What happens:

No & that divides the client_id and state parameters resulting in incorrect hash for clientId.

The URL should be: https://oauth.bunq.com/auth?response_type=code&redirect_uri=redirecturi&client_id=client_idstate=state

SDK version and environment

angelomelonas commented 4 years ago

Hi @Nayels,

Thanks for raising this issue! 🙏🏼 I see we already have a pending PR for it. This will be fixed in the upcoming release (1.14.1).