bunq / sdk_java

Java SDK for bunq API
MIT License
49 stars 23 forks source link

Add pagination; cleanup; add missing endpoints and fields [#4] #13

Closed dnl-blkv closed 7 years ago

dnl-blkv commented 7 years ago

@OGKevin All fixed! For all the generated files, let's remember it and look into it later / fix all the docs in the proper place :)

OGKevin commented 7 years ago

@dnl-blkv ack, LGTM. Will run tests before I approve. Will make PR tonight for the generated code as well 😉.

OGKevin commented 7 years ago

@dnl-blkv all tests passing, please include pagination tests as we discussed and it can be merged 👏

OGKevin commented 7 years ago

All tests passing, LGTM @andrederoos please take a look.

dnl-blkv commented 7 years ago

@andrederoos no need for this magic; @OGKevin already found that way. It is just an old PR. In the future PRs, the generated code will be auto-collapsed.

andrederoos commented 7 years ago

awesome!