search

bunq / sdk_java

Java SDK for bunq API
MIT License
49 stars 23 forks source link

Response is missing response headers and pagination #4

Closed dnl-blkv closed 7 years ago

dnl-blkv commented 7 years ago

How to Reproduce

  1. Make a valid listing request to bunq API via the Java SDK
  2. Make a valid get/put/post/delete request to bunq API via the Java SDK

What Should Happen

  1. The response contains response headers and pagination
  2. The response contains response headers

What Happens

  1. The response does not contain response header nor pagination
  2. The response does not contain response header

Notes

  1. The structural fix would be to introduce BunqResponse object which, besides the response model, includes the response headers and pagination
OGKevin commented 7 years ago

Closing I favour of #5

dnl-blkv commented 7 years ago

@OGKevin but pagination is sill not in!

OGKevin commented 7 years ago

Ah, i was closing all the issue in the milestone 😊.

0.11.0 ?

dnl-blkv commented 7 years ago

Yes please! :)

OGKevin commented 7 years ago

Closing in favour of #13