Closed ChappIO closed 6 years ago
My apologies, I just noticed this was already fixed in a way quite similar to option 2. I will build application using the develop branch for now and wait for the official release.
Hey ChappIO,
This is indeed a duplicate of bunq/sdk_java#46 and will be fixed in the 0.12.5
release.
Im hoping to release it beginning next week after fixing bunq/sdk_java#25.
@OGKevin thank you very much. I won't finish my application by then anyway, so I will upgrade after the release :)
Steps to reproduce:
What should happen:
What happens:
Traceback
SDK version and environment
Response id
Extra info:
Currently
com.bunq.sdk.model.generated.object.Geolocation
has threeBigDecimal
fields. However, there seems to be a mismatch. If you take a look atcom.bunq.sdk.json.BigDecimalTypeAdapter
it reads aBigDecimal
from typeString
. Yet the api returns a value of type number.I did not make the pull request myself because I don't know which fix you'd like me to make. I see a few options:
String
. However, this is probably extremely impactful as it is a breaking api change.com.bunq.sdk.json.BigDecimalTypeAdapter
so it becomesGeolocation
useDouble
s instead ofBigInteger
sMy personal preference would go to option 2 since in my opinion it is a more resilient solution. I am willing to make the pull request myself. Just give me your decision.