search

bunq / sdk_php

PHP SDK for bunq API
MIT License
84 stars 54 forks source link

Separation of concerns: InstallationUtil class is displaying error messages #133

Closed jorijn closed 6 years ago

jorijn commented 6 years ago

Steps to reproduce:

  1. Use the InstallationUtil to create ApiContext
  2. Be in such state than an exception is thrown

What should happen:

  1. InstallationUtil should throw the exception.
  2. The exception is not caught, displaying the whole stack trace instead of the main error message.

What happens:

  1. InstallationUtil is catching the exception and printing it, instead of terminating the code execution.

needs #137