separated responsibilities: displaying the error message belongs in `bunq-install`

bunq / sdk_php

PHP SDK for bunq API

MIT License

84 stars 54 forks source link

separated responsibilities: displaying the error message belongs in `bunq-install` #134

Closed jorijn closed 6 years ago

jorijn commented 6 years ago

If looking at the separation of concerns principles, this should happen in bin/bunq-install instead. Moving these try/catch blocks will allow proper extension and usage of automated registration in other code.

This PR closes/fixes the following issues:

Closes bunq/sdk_php#133
- [ ] Tested

OGKevin commented 6 years ago

@Jorijn thanks for your contribution. Do you mind following the guidelines and format your commit msg accordingly.

My commit. (bunq/sdk_php#133) in your case.

jorijn commented 6 years ago

Re-creating pull request with proper commit message included, closing this one.