Closed OGKevin closed 6 years ago
https://github.com/bunq/sdk_php/blob/652e650aa35a8c0c598653e986ac7f68d4808bdd/src/Context/ApiContext.php#L332
Instead of giving the default value a proper value, it should be null. Instead the method body we will then check if the parameter is null or not.
This way, in other places we should not check if we are going to pass null or not. e.g. https://github.com/bunq/sdk_php/blob/652e650aa35a8c0c598653e986ac7f68d4808bdd/src/Util/InstallationUtil.php#L169-L173
https://github.com/bunq/sdk_php/blob/652e650aa35a8c0c598653e986ac7f68d4808bdd/src/Context/ApiContext.php#L332
Instead of giving the default value a proper value, it should be null. Instead the method body we will then check if the parameter is null or not.
This way, in other places we should not check if we are going to pass null or not. e.g. https://github.com/bunq/sdk_php/blob/652e650aa35a8c0c598653e986ac7f68d4808bdd/src/Util/InstallationUtil.php#L169-L173