search

bunq / sdk_php

PHP SDK for bunq API
MIT License
84 stars 54 forks source link

[epic] Revamp readme #139

Closed OGKevin closed 5 years ago

OGKevin commented 6 years ago

Whit the release of tinker, we will now use that as example. So example references to the example folder should be pointed to tinker code.

OGKevin commented 6 years ago
do-not-edit-start-codetree-epic-issues

Issues in this epic:

Title Milestone Assignees Stage State
[php] Update examples in readme #140 1.0.0 OGKevin Closed
[csharp] Update examples in readme #91 1.0.0 OGKevin Closed
[python] Update examples in readme #87 0.13.5 OGKevin Closed
[Java] Update examples in readme #81 1.0.0 OGKevin Closed
do-not-edit-end-codetree-epic-issues
Wouter0100 commented 6 years ago

Listing monetary accounts example does not seem to work. Corrected one:


$monetaryAccountList = MonetaryAccount::listing();

foreach ($monetaryAccountList->getValue() as $monetaryAccount) {
    var_dump($monetaryAccount->getReferencedObject()->getDescription() . PHP_EOL);
}
``
OGKevin commented 6 years ago

@Wouter0100 😁 nice stop, feel free to create a PR to fix this :). Do you mind checking the readme's of the other 2 SDK's and create a PR ? They are referenced in the comment above.

Wouter0100 commented 6 years ago

Sure! @OGKevin I'll get back to you asap when I have a complete overview and implemented the features I need :)