bunq / sdk_php

PHP SDK for bunq API
MIT License
84 stars 54 forks source link

Add support for the undocumented user/%s/monetary-account/%s/customer-statement/%s/content call #147

Closed karstennilsen closed 6 years ago

karstennilsen commented 6 years ago

You can get all the information of a customer statement, but you can't actually download the customer statement. Please add a content() function in CustomerStatementExport.php.

For now I added for myself: /**

OGKevin commented 6 years ago

I think this is what you are looking for ? https://github.com/bunq/sdk_php/blob/8c1faefc111d9b970168a1837ca165d854954941/src/Model/Generated/Endpoint/CustomerStatementExportContent.php#L8-L16

karstennilsen commented 6 years ago

Yes, couldn't find that :+1: Issues solved! By the way, this call is not at all mentioned on doc.bunq.com, doesn't make stuff easier...

OGKevin commented 6 years ago

@karstennilsen i dont understand ? Its listed as the second endpoint under https://doc.bunq.com/#tag/content

karstennilsen commented 6 years ago

Lol, ok this proves your manual is impossible to read :) You expect this in the customer-statement category. Maybe in each case add a mention in the customer-statement response 200 like you did in the year export.

OGKevin commented 6 years ago

the doc is categorized on endpoints. This falls under the /content endpoint.

karstennilsen commented 6 years ago

Totally fine. The only point I'm trying to make is that I as quite experienced developer couldn't find it. I even gave a suggestion (which is e.g. already done in the export-anual-overview) so people like me (your dev customers) understand your API.