search

bunq / sdk_php

PHP SDK for bunq API
MIT License
84 stars 54 forks source link

BunqContext class file duplicated #155

Closed janxb closed 6 years ago

janxb commented 6 years ago

Steps to reproduce:

  1. look at the source files in master -> /src/Context/

What should happen:

  1. There should only be one file containing class BunqContext, named "BunqContext.php"

What happens:

  1. There are two files containing class BunqContext, named "BunqContext.php" and "bunqContext.php"

Extra info:

This issue seems fixed in the develop branch, but as it is not in master, composer is still complaining about this. Maybe you can remove the duplicated file from master and build a new version containing this fix?

bunqcontext-class-duplicated

OGKevin commented 6 years ago

Yes, this will be fixed in the 1.0.0 release, however for the 1.0.0 release i want to release all the SDK's at the same time.

Is there a reason why this can not wait until the release and should be hotfixed ?

duplicate of #114

janxb commented 6 years ago

Sorry for the late response. If this issue will be fixed, it's enough. No need for a hotfix. Thanks for your work! :) I will keep this issue open, maybe you can close it when the new version of the SDK including the fix has been released.