search

bunq / sdk_php

PHP SDK for bunq API
MIT License
84 stars 54 forks source link

Incorrect name space for BunqException #166

Closed OGKevin closed 4 years ago

OGKevin commented 5 years ago

Steps to reproduce:

  1. Trigger an BunqException from generated code

What should happen:

  1. The exception gets thrown

What happens:

  1. Because the generated code is using an incorrect namespace, a fatal happends.

Traceback

SDK version and environment

Extra info:

https://github.com/bunq/sdk_php/blob/982bd08d43293c2766c7fcc094cd55b4e6b06687/src/Exception/BunqException.php#L2

https://github.com/bunq/sdk_php/blob/982bd08d43293c2766c7fcc094cd55b4e6b06687/src/Model/Generated/Endpoint/MonetaryAccount.php#L4

filoor commented 5 years ago

Any idea when this will be fixed?

OGKevin commented 5 years ago

Any idea when this will be fixed?

🤷‍♂️ unfortunately, I can't fix this as I no longer have access to the generator. This is a bug in the generator and therefore needs bunq's internal people to fix it.

e.g: @kojoru @JordyHeemskerk

filoor commented 5 years ago

Thanks @OGKevin thanks, Hope that @kojoru @JordyHeemskerk will soon have time for it can not import my data now in firefly iii :(

OGKevin commented 5 years ago

@filoor I've been trying 🙃 https://together.bunq.com/d/5398-savings-account-has-been-added-to-the-pub-api

OGKevin commented 5 years ago

however, the issue that is preventing you from doing the import is #165 and not this one 😉

filoor commented 5 years ago

@OGKevin HAHAHAH i willtry to help you 🗡

OGKevin commented 5 years ago

Can this plz be fixed -.-. its a simple generator code template typo.

angelomelonas commented 4 years ago

@OGKevin I have fixed this on the generator so this will be fixed in the next planned release (1.14.1).

OGKevin commented 4 years ago

I don't use bunq anymore 🤷.