search

bunq / sdk_php

PHP SDK for bunq API
MIT License
83 stars 54 forks source link

Enhancement: Add support for PHP 8.0 and updated minimal php version to 7.3 #212

Closed EJTJ3 closed 2 years ago

EJTJ3 commented 3 years ago

//: # (Thanks for opening this pull request! Before you proceed please make sure that you have an issue that explains what this pull request will do. Make sure that all your commits link to this issue e.g. "My commit. (bunq/sdk_php#)". If this pull request is changing files that are located in "src/Model/Generated" then this pull request will be closed as these files must/can only be changed on bunq's side.)

This PR closes/fixes the following issues:

basepack commented 2 years ago

Is this commit still being worked on?

EJTJ3 commented 2 years ago

Looks like this repository is no longer maintained.

HVSoftware commented 2 years ago

@EJTJ3 I see you have made an MR which support the latets version of PHP. I also want to use this feature. Would it be an option to spilt the issue into multiple MR's. Like update to PHP 7.4, followed by an MR to update to PHP 7.4 and 8.0? Maybe when the changes are smaller the MR can be accapted faster.

EJTJ3 commented 2 years ago

@HVSoftware I've updated the minimal php version to 7.3 to keep the changes as small as possible. The problem is that bunq no longer actively maintains its repositories.

basepack commented 2 years ago

@EJTJ3 Thanks for that! But do you know the reason why bunq does not maintain them anymore?

HVSoftware commented 2 years ago

Don't know why they don't maintain the repository anymore. I have sent them an email. Otherwise I try to contact them in a different way.

HVSoftware commented 2 years ago

I've received a mail from the support department. They will delegate the request to the correct department.

EJTJ3 commented 2 years ago

Did you hear anything from Bunq?

basepack commented 2 years ago

@HVSoftware did you receive any news from Bunq?

HVSoftware commented 2 years ago

@basepack They just merged the PR.

basepack commented 2 years ago

@HVSoftware yes I saw that, but I thought maybe you now also got the reason why they do not maintain this repo. Because to quote myself: "But do you know the reason why bunq does not maintain them anymore?"

And to quote your reaction later: "Don't know why they don't maintain the repository anymore. I have sent them an email. Otherwise I try to contact them in a different way."

So I thought maybe you now know why they do not maintain it anymore?

HVSoftware commented 2 years ago

@basepack I did not received a clear reason why there was no maintenance done anymore on this repository since the last months. I've send them a mail and ask the why question. I will keep you updated when I receive more information.

EJTJ3 commented 2 years ago

@HVSoftware Thanks! I hope @bunq-bot will release a new version soon!

HVSoftware commented 2 years ago

@EJTJ3 I have sent them a request by email to release a new version.