Fix #221 No implicit cast of microtime needed

[erkens]

This fix will make sure the implicit cast of microtime is not done anymore, because it has been done in a new variable, which also means that the "cast" is only done once, because it was already needed for the floor()-function.

It should work on all supported PHP versions, but I only tested it with 8.1

• Closes bunq/sdk_php#221
  • [x] Tested

[erkens]

Is bunq maintaining their API? Please merge this or give at least a reaction why you won't include this...

[StanJansen]

Hi @sailingdeveloper , sorry for tagging, but I noticed you picked up the last PR that got merged.

This issue causes the SDK to no longer work for us, and we'd prefer not having to create a fork. Could this be looked at / merged, or if a new PR needs to be made as this one is quite old i'd be happy to do that.

We temporarily created a fork with the following change in src/Context/SessionContext.php:

• Replaced return static::microTimeToDateTime($expiryTime); with return DateTime::createFromFormat('U.u', $expiryTime);
• Removed private static function microTimeToDateTime as a whole

If this SDK will no longer be maintained we'd also like to know it so we can look for alternatives.

[sailingdeveloper]

@StanJansen Merged for now, but this will be reverted as soon as the next backend version is released, which happens often 😅

I’ll take a look if we can fix this structurally 🙏

[StanJansen]

@StanJansen Merged for now, but this will be reverted as soon as the next backend version is released, which happens often 😅

I’ll take a look if we can fix this structurally 🙏

Thanks for the quick reply! That would be great :pray: