Initial feedback on project (organization)

[holtkamp]

Some feedback on the current approach:

• why support both PHP 5.6 AND 7 and not only use / support PHP 7?
  • this is a new SDK, might be good to use that in your advantage by reducing need for backward compatibility of PHP 5.6
  • way better support for scalar and complex types, reducing chance of bugs / extensive unit tests
  • support for visibility (public, protected, private) of constants, which seem to be used extensively in the code
• version number in composer.json should be omitted
• composer.lock should probably not be committed to repository and part of .gitignore
• .idea folder should probably not be committed to repository and part of .gitignore
• the lib folder should "probably" be renamed to src
  • I believe this is not a "hard" rule, more of a PSR4 coding convention... lib suggests 3rd party code, while src is "your" code...

[dnl-blkv]

@holtkamp

Thanks for the feedback, we'll go through it!

I can immediately respond regarding the first point: we will eventually switch to PHP 7.0 only. We use it ourselves. However, the most recent Developer Ecosystem Survey suggests that 5.6 is still widely used (more than 7.0). Moreover, the end-of-life for it is scheduled on December 31st, 2018, which is still a way to go.

Sources

• https://www.jetbrains.com/research/devecosystem-2017/php/
• http://php.net/supported-versions.php

[LauLaman]

other suggestions:

• Use travis to run automatic testing so each PR is tested before its merged to master.
• Use scrutinizer to keep the code quality high
• install the awesome badges in README.md:

[dnl-blkv]

@LauLaman Thanks, these are valid improvements. We will implement those in a near future.

[holtkamp]

FYI: https://gophp71.org, would aim for PHP 7.1 😄