search

bunq / sdk_python

Python SDK for bunq API
MIT License
106 stars 25 forks source link

Missing id on list of share-invite-bank-response #104

Open WouterLok opened 5 years ago

WouterLok commented 5 years ago

Steps to reproduce:

  1. Create a API-context using the Python Tinker Lib for account A

  2. Create a ShareInvideBankInquery from the main account from the current user to another user using the method endpoint.ShareInviteBankInquery.create from the python SDK

  3. Create a API-context using the Python Tinker Lib for account B

  4. Get the list of outstanding PENDING requests using the method endpoint.ShareInviteBankResponse.list from the python SDK

What should happen:

  1. In step 4, the result should contain a list of Pending ShareInviteBankResponse objects, identified by the draft_share_invite_bank_id.

What happens:

  1. While the list of Pending Responses is returned, the draft_share_invite_bank_id has value 'None'. Since no ID is known, it is not possible to accept the pending request.

Traceback

Printed Object Example:

{'_monetary_account_id': None, '_draft_share_invite_bank_id': None, '_counter_alias': <bunq.sdk.model.generated.object_.MonetaryAccountReference object at 0x7fd649006c18>, '_user_alias_cancelled': None, '_description': 'bunq account', '_share_type': 'STANDARD', '_status': 'PENDING', '_share_detail': <bunq.sdk.model.generated.object_.ShareDetail object at 0x7fd649006ef0>, '_start_date': None, '_end_date': None}

SDK version and environment

Response id

Extra info:

WouterLok commented 5 years ago

Also, the Sandbox Android App does show the Pending requests and i am able to Accept the requests with the app.

OGKevin commented 5 years ago

Thanks for reporting. Is an ez fix and should be fixed In the next release.