search

bunq / sdk_python

Python SDK for bunq API
MIT License
106 stars 25 forks source link

Minimum Python version to 3.5.3 #108

Closed eavanvalkenburg closed 5 years ago

eavanvalkenburg commented 5 years ago

Is it really using 3.6 specific functions? (change #85) I'm working on integrating this with Home Assistant (#home-assistant/home-assistant/pull/17478) , but it has a minimum python version of 3.5.3 and so it won't work right now. And quickly looking through the 3.6 changes, I don't see much things there that effect this sdk (for instance there are no f-strings used).

SDK version and environment

eavanvalkenburg commented 5 years ago

It seemed to have been a fix based on this issue: https://github.com/bunq/sdk_python/issues/73#issuecomment-365378541 and that was fixed in Python 3.5.

OGKevin commented 5 years ago

The issue you reference is indeed the reason why the minimum python version got raised.

If you can decrease it to 3.5 and ensure that nothing explodes while running it on 3.5 then I don’t see a reason why to no decrease it 3.5 😊

eavanvalkenburg commented 5 years ago

The issue you reference is indeed the reason why the minimum python version got raised.

If you can decrease it to 3.5 and ensure that nothing explodes while running it on 3.5 then I don’t see a reason why to no decrease it 3.5 😊

ok, great, I'll try to test that next week!

OGKevin commented 5 years ago

Thanks for your contribution @eavanvalkenburg :)

eavanvalkenburg commented 5 years ago

Thanks @OGKevin, any idea when you guys will do a new release to pypi?

kojoru commented 5 years ago

@eavanvalkenburg we'll iron out a few more things on our side first and then do a release. Shouldn't take longer than a few days.

eavanvalkenburg commented 5 years ago

@kojoru any updates on this?

eavanvalkenburg commented 5 years ago

guys? @kojoru @OGKevin

OGKevin commented 5 years ago

@eavanvalkenburg unfortunately i've been removed as maintainer so i cant help you here :( its up to @kojoru