search

bunq / sdk_python

Python SDK for bunq API
MIT License
106 stars 25 forks source link

Add missing _user_payment_service_provider variable with the value None to session_server #135

Closed siccovansas closed 4 years ago

siccovansas commented 4 years ago

I ran into this issue #134. When I add the line in this commit it fixes it for me. I have no idea if this is indeed a bug on Bunq's side and if this pull request fixes (all of) it, but to me it seems like it :). Please check if I'm correct.

Also the code in sdk_python/bunq/sdk/json/session_server_adapter.py contains quite a few mentions of USER_PAYMENT_SERVER_PROVIDER, I guess this should be USER_PAYMENT_SERVICE_PROVIDER?

This PR closes/fixes the following issues:

siccovansas commented 4 years ago

@angelomelonas @lexym @NickvandeGroes could any of you take a look at this PR? It has been open for 2.5 months and there has been no reaction even though there have been new commits and even a new release.

angelomelonas commented 4 years ago

Hey @siccovansas, you're right! It was missing but it isn't any more 👍 Thanks for helping us fix it!