search

bunq / sdk_python

Python SDK for bunq API
MIT License
106 stars 25 forks source link

Response is missing response headers and pagination #9

Closed dnl-blkv closed 7 years ago

dnl-blkv commented 7 years ago

How to Reproduce

  1. Make a valid listing request to bunq API via the Python SDK
  2. Make a valid get/put/post/delete request to bunq API via the Python SDK

What Should Happen

  1. The response contains response headers and pagination
  2. The response contains response headers

What Happens

  1. The response does not contain response header nor pagination
  2. The response does not contain response header

Notes

  1. The structural fix would be to introduce BunqResponse object which, besides the response model, includes the response headers and pagination
OGKevin commented 7 years ago

Related to #8

OGKevin commented 7 years ago

Closing as #10 has been merged.