bunqCommunity / bunqDesktop

The unofficial, free and open source desktop application for the bunq API
https://bunqdesk.top
MIT License
272 stars 53 forks source link

Display payment type #18

Closed basst85 closed 6 years ago

basst85 commented 6 years ago

The payment/transaction type is missing in the payment info screen. Like: iDEAL, pintransaction, cash withdrawal..

basst85 commented 6 years ago

The information on https://doc.bunq.com/api/1/call/payment/method/get is not 100% up-to-date. You have payment type "MASTERCARD", this is for pintransactions and also cash withdrawals, so that makes it a bit tricky.

And the there is also a undocumented response attribute Payment->counterparty_alias->merchant_category_code, with one of these values: https://github.com/greggles/mcc-codes/blob/master/mcc_codes.csv

craftbyte commented 6 years ago

@basst85 the MASTERCARD type shouldn't be a problem, since the subtypes still apply

basst85 commented 6 years ago

@craftbyte In the API documentation (https://doc.bunq.com/api/1/call/payment/method/get) there is a sub_type, but i don't see any in the real payment response JSON (in production)..

Crecket commented 6 years ago

It now shows the type that is included with the payment object. I'll look into adding the sub types and/or merchant categories later

basst85 commented 6 years ago

https://together.bunq.com/topic/sub_type-missing-in-payment-response#comment-20397