search

bunqCommunity / bunqDesktop

The unofficial, free and open source desktop application for the bunq API
https://bunqdesk.top
MIT License
272 stars 52 forks source link

Negative amount does not follow regional conventions #288

Closed JeroenEeuwes closed 6 years ago

JeroenEeuwes commented 6 years ago

I asked for the minus sign in this request for negative amounts. In the Nightly build 2018-08-27 23:04:54 this was changed. The minus sign is before the Euro sign which is not according to my regional settings. Below a screenshot of all the possibilities that Windows allows. My selection is the default for the Dutch region.

I know I did not ask to follow the regional settings, but only for a minus sign :innocent: Anyway, I think it would be better to follow the regional settings. In Linux this is the same, but then using the locale settings. I don't know how this works on MacOS.

This is the advise of the Nederlandse Taalunie (in Dutch) about the place of the minus sign.

negative

basst85 commented 6 years ago

The region can be added as a header to the http request (X-Bunq-Region), how does the bunq API handle this?

Crecket commented 6 years ago

image I modified it a bit to use the nl locale setting and it seems to use the same format now 👍