bunqCommunity / bunqDesktop

The unofficial, free and open source desktop application for the bunq API
https://bunqdesk.top
MIT License
272 stars 53 forks source link

build: add Electron linux Dockerfile + auto build image #555

Closed firstred closed 4 years ago

firstred commented 4 years ago

Adds an Electron builder Docker file for Linux images.

This Docker file includes downloading nvm and installing node 12 LTS so that all environments are running the same version.

Crecket commented 4 years ago

Not sure if we should handle that dockerfile ourselves, I'd rather leave that kind of stuff to the electron devs if possible

firstred commented 4 years ago

Yeah, you're making a good point. I have been wondering myself if this was the correct approach.

We could also use that Dockerfile to pull their image (electronuserland/builder:wine) and only swap the node version so that they are still in control of the whole image, and we can always decide which node version to use.

firstred commented 4 years ago

Is this better?