Closed ties-s closed 5 years ago
Merging #30 into master will increase coverage by
0.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 97.26% 97.31% +0.05%
==========================================
Files 61 61
Lines 1972 1972
Branches 391 391
==========================================
+ Hits 1918 1919 +1
+ Misses 53 52 -1
Partials 1 1
Impacted Files | Coverage Ξ | |
---|---|---|
src/Crypto/Aes.ts | 100% <0%> (+2.85%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update f6f4c5d...59bef77. Read the comment docs.
Thanks π I have some basic Typescript experience but setting up the types correctly was giving me a ton of issues when I tried it early on.
This should enable support for auto complete in VSCode and other editors.
You may also want to move @babel/*
to devDependencies
. As far as I know they also only needed for building.
Will you publish to npm or should I install from the repo for now?
I'll publish it now π
I think you forgot to build before publishing
Should be good now on 0.35.2, it looks like the npmignore file also needs to include a bunch of the files/folders listed in the gitignore file.
This PR will:
main
property ofpackage.json
to./dist/BunqJSClient.js
types
property ofpackage.json
to./dist/BunqJSClient.d.ts
and removes thetypings
as they are interchangeable./dist
to.gitignore
, this prevents cluttering commits with build files/src
to.npmignore
this keeps download size while installing the package low@types/*
dependencies todevDependencies
because they are only needed during development