Closed ties-s closed 5 years ago
Fails on
Summary of all failing tests
FAIL tests/src/RequestLimiter.test.ts
● RequestLimiter › #wrapCallable() › should allow for non-promise callbacks
TypeError: queueItem.callable(...).then is not a function
at RequestLimiter.check (src/RequestLimiter.ts:1222:32)
at RequestLimiter.run (src/RequestLimiter.ts:1343:12)
at Object.it (tests/src/RequestLimiter.test.ts:41:43)
at new Promise (<anonymous>)
I'm guessing then() isn't defined on non-promise values like you're using there. I'll fix this tomorrow if you haven't already by then.
Thanks for all the pull requests btw 👍
Merging #33 into master will decrease coverage by
<.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
- Coverage 97.31% 97.3% -0.01%
=========================================
Files 61 61
Lines 1972 1967 -5
Branches 391 390 -1
=========================================
- Hits 1919 1914 -5
Misses 52 52
Partials 1 1
Impacted Files | Coverage Δ | |
---|---|---|
src/RequestLimiter.ts | 97.82% <100%> (-0.22%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 938f774...9280de2. Read the comment docs.
Fixed it :)
Thanks for the fix :+1:
Prevent always catching errors and let them be handled by the developer. Current situation will always catch errors and print a huge message to the console.