search

bunqCommunity / bunqJSClient

A javascript SDK for the bunq API
MIT License
58 stars 23 forks source link

Add missing notification type #34

Closed ties-s closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #34 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #34   +/-   ##
======================================
  Coverage    97.3%   97.3%           
======================================
  Files          61      61           
  Lines        1967    1967           
  Branches      390     390           
======================================
  Hits         1914    1914           
  Misses         52      52           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab87536...a9786ac. Read the comment docs.

Crecket commented 5 years ago

I'm actually about to add a check for the prettier styling which will fail on styling like this in the future. Could you run the yarn run prettier script before committing?

And thanks for adding this, I noticed a few new types throughout the docs already but I probably missed a few