search

bunqCommunity / bunqJSClient

A javascript SDK for the bunq API
MIT License
58 stars 23 forks source link

Fix encryption so that API doesn't return sign/HMAC errors #41

Closed kojoru closed 5 years ago

kojoru commented 5 years ago

These changes work with bunq's encryption endpoints according to my (non-extensive) testing.

codecov[bot] commented 5 years ago

Codecov Report

Merging #41 into cvc-generation will decrease coverage by <.01%. The diff coverage is 20%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           cvc-generation      #41      +/-   ##
==================================================
- Coverage           94.76%   94.76%   -0.01%     
==================================================
  Files                  63       63              
  Lines                2044     2042       -2     
  Branches              397      397              
==================================================
- Hits                 1937     1935       -2     
  Misses                106      106              
  Partials                1        1
Impacted Files Coverage Δ
src/HTTP/EncryptRequestHandler.ts 27.77% <0%> (ø) :arrow_up:
src/HTTP/SignRequestHandler.ts 79.16% <0%> (ø) :arrow_up:
src/Crypto/Sha256.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27831fa...8c53411. Read the comment docs.