Closed firstred closed 4 years ago
Thanks for this! Could you run the yarn run prettier
command to fix the styling? The test is failing on The ShareInviteMonetaryAccountResponse file but the rest looks good to go. I'll release a new major version for this since this is breaking (which bunq doesn't seem to understand lol)
Merging #51 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 71 71
Lines 2236 2236
Branches 461 461
=======================================
Hits 2206 2206
Misses 29 29
Partials 1 1
Impacted Files | Coverage Δ | |
---|---|---|
src/Api/ShareInviteMonetaryAccountResponse.ts | 100% <100%> (ø) |
|
src/Api/index.ts | 100% <100%> (ø) |
:arrow_up: |
src/Api/ShareInviteMonetaryAccountInquiry.ts | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dc03be4...e35f56a. Read the comment docs.
Sure! I just updated the code style. If you want, I can add Husky to force prettier as a pre-commit hook.
Which test is failing for you? I just ran the tests again, but the ShareInviteMonetaryAccountResponse
tests still work. I did rename the files, though.
BTW, has Travis CI been disabled for pull requests? I didn't see any test results.
I'll release a new major version for this since this is breaking (which bunq doesn't seem to understand lol)
Yeah, that might be the best course of action I'm afraid ^^ As far as I can tell only the endpoint has been renamed, but maybe bunq has plans to change the response in the future. Who knows? (Not me :smile:)
This implements the July 9th, 2019 change from the changelog: https://beta.doc.bunq.com/basics/changelog#july-9-2019
This should be enough to fix the current bank inquiry/response problems in bunqDesktop.