search

bunqCommunity / bunqJSClient

A javascript SDK for the bunq API
MIT License
58 stars 23 forks source link

feat: Update 13 changes #56

Closed firstred closed 4 years ago

firstred commented 4 years ago

This PR contains the Update 13 changes from the changelog: https://beta.doc.bunq.com/basics/changelog#january-28-2020-bunq-update-13-edition

Signing the URL and headers is deprecated and will be removed soon. Also, there are now a lot of endpoints that do not require signing at all. I have double-checked whether this is true, and indeed, the API ignores the signature for all operations except the ones listed here: https://beta.doc.bunq.com/basics/authentication/signing Despite these changes, this PR still signs all requests, in case additional endpoints are added, that do require signing. This way, we don't have to think about it anymore.

codecov[bot] commented 4 years ago

Codecov Report

Merging #56 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   98.65%   98.64%   -0.01%     
==========================================
  Files          71       71              
  Lines        2236     2221      -15     
  Branches      461      456       -5     
==========================================
- Hits         2206     2191      -15     
  Misses         29       29              
  Partials        1        1
Impacted Files Coverage Δ
src/HTTP/SignRequestHandler.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 067ae9c...c858cb0. Read the comment docs.