search

bunqCommunity / bunqJSClient

A javascript SDK for the bunq API
MIT License
58 stars 23 forks source link

fix: TypeScript detected type issue #58

Closed firstred closed 4 years ago

firstred commented 4 years ago

Fixes a trivial issue detected by TypeScript 3.7.

TypeScript detects the type of this.encryptionKey as string | true, which is correct because line 107 in Session.ts makes sure it's no longer false. To fix this error in TS, I have changed it to only guard against an empty API key.

codecov[bot] commented 4 years ago

Codecov Report

Merging #58 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          71       71           
  Lines        2236     2236           
  Branches      461      461           
=======================================
  Hits         2206     2206           
  Misses         29       29           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ec03fa...2344ad0. Read the comment docs.